[tor-bugs] #16013 [Tor]: Assertion ENTRY_TO_CONN(conn)->state == AP_CONN_STATE_CIRCUIT_WAIT failed in circuit_get_open_circ_or_launch at circuituse.c:1835

[Tor Bug Tracker & Wiki]

#16013: Assertion ENTRY_TO_CONN(conn)->state == AP_CONN_STATE_CIRCUIT_WAIT failed
in circuit_get_open_circ_or_launch at circuituse.c:1835
-----------------------------+-------------------------------------
     Reporter:  cypherpunks  |      Owner:  nickm
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  regression 026-backport
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------

Comment (by dgoulet):

 Replying to [comment:25 nickm]:
 > I have attached a possible patch.  Does this fix the issue for you?

 That snippet of code, shouldn't be at the top of the function because it
 sounds like if weren't in the WAIT state, there is no point to try to
 attach and do anymore work? or do we?

 I am asking because prior to this check, `conn` can get modified like for
 instance `conn->chosen_exit_optional = 0`. If it doesn't need to be at the
 top, I would like to know why the added check is valid at this point in
 the function not before (comment?).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16013#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online