[tor-bugs] #16222 [Tor Browser]: Review networking code for Firefox 38

[Tor Bug Tracker & Wiki]

#16222: Review networking code for Firefox 38
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  mikeperry              |     Status:  needs_review
         Type:  task     |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  ff38-esr, tbb-5.0a3-essential,
  Browser                |  TorBrowserTeam201506R, MikePerry201506,
   Resolution:           |  GeorgKoppen201506
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Replying to [comment:4 mikeperry]:
 >  * Roku Screen Sharing is FxOS/Android only, but will bypass proxy
 settings if enabled.

 Note that RokuApp.jsm is present in desktop Firefox builds.  Flipping
 browser.casting.enabled to true enables it.  I do not have a Roku device,
 but I assume it works.

 >  * SimpleServiceDiscovery (related to Roku screen sharing) can also
 bypass proxy settings, and I'm not 100% sure it's not compiled in on the
 desktop. The moz.build files are a bit hard to follow here.

 Unfortunately, it is included in desktop builds.  But the "search the
 local network for services" part that uses the network will not be
 executed unless browser.casting.enabled == true.

 It makes me a little nervous to include code like this even though it is
 pref'd off.  I guess it is no worse than a lot of other things.  But it
 looks like we could remove the RokuApp.jsm and SimpleServiceDiscovery.jsm
 files from our builds without breaking anything in the default situation
 (things will break if someone sets browser.casting.enabled = true and
 restarts their browser).

 Opinions?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16222#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online