[tor-bugs] #16013 [Tor]: Assertion ENTRY_TO_CONN(conn)->state == AP_CONN_STATE_CIRCUIT_WAIT failed in circuit_get_open_circ_or_launch at circuituse.c:1835

[Tor Bug Tracker & Wiki]

#16013: Assertion ENTRY_TO_CONN(conn)->state == AP_CONN_STATE_CIRCUIT_WAIT failed
in circuit_get_open_circ_or_launch at circuituse.c:1835
-----------------------------+-------------------------------------
     Reporter:  cypherpunks  |      Owner:  nickm
         Type:  defect       |     Status:  accepted
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  regression 026-backport
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------
Changes (by nickm):

 * status:  needs_revision => accepted
 * owner:   => nickm


Comment:

 This is key:
 {{{
 Jun 21 19:22:56.000 [err] circuit_get_open_circ_or_launch(): Bug:
 Connection state mismatch: wanted AP_CONN_STATE_CIRCUIT_WAIT, but got 6
 (waiting for rendezvous desc)
 }}}

 And so is this:
 {{{
 #2  circuit_get_open_circ_or_launch (conn=conn at entry=0x612000246dc0,
 desired_circuit_purpose=desired_circuit_purpose at entry=7 '\a',
 circp=circp at entry=0x7fffed22fe30) at src/or/circuituse.c:1841
 #3  connection_ap_handshake_attach_circuit
 (conn=conn at entry=0x612000246dc0) at src/or/circuituse.c:2425
 }}}

 Note that when we first entered connection_ap_handshake_attach_circuit,
 conn->state was CIRCUIT_WAIT, since otherwise the assertion at the start
 of connection_ap_handshake_attach_circuit would have failed.  Also, the
 second invocation of circuit_get_open_circ_or_launch is hitting the
 assertion.  The first invocation must have returned 0.  Finally, somewhere
 between the beginning of the first invocation of
 circuit_get_open_circ_or_launch and the second, we changed the state of
 the conn to DESC_WAIT.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16013#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online