[tor-bugs] #16260 [Tor]: HS can repick an expired intro points or one that we've already picked

[Tor Bug Tracker & Wiki]

#16260: HS can repick an expired intro points or one that we've already picked
-------------------------+--------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  SponsorR, tor-hs
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by nickm):

 The big conditional we removed, the one starting with
 {{{
 -  if (tor_memneq(intro->extend_info->identity_digest,
 -      launched->build_state->chosen_exit->identity_digest, DIGEST_LEN)) {
 -    char cann[HEX_DIGEST_LEN+1], orig[HEX_DIGEST_LEN+1];
 }}}

 I'm guessing you removed that because it can't happen, right?  Should that
 become an assertion or something in that case?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16260#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online