[tor-bugs] #16376 [Tor Browser]: When I close TorBrowser 4.5.1, it clears clipboard.

[Tor Bug Tracker & Wiki]

#16376: When I close TorBrowser 4.5.1, it clears clipboard.
--------------------------------+---------------------------
     Reporter:  Ilya_SpongeBob  |      Owner:
         Type:  defect          |     Status:  closed
     Priority:  major           |  Milestone:
    Component:  Tor Browser     |    Version:
   Resolution:  not a bug       |   Keywords:  tbb-usability
Actual Points:                  |  Parent ID:
       Points:                  |
--------------------------------+---------------------------

Comment (by Ilya_SpongeBob):

 Please stop reopening this ticket, as that is considered rude by some
 people.

  gk has already closed this ticket twice

 You have closed tichet because you have lied all is workding for you. This
 is really rude.

  I've provided you an explanation as to why the feature is the way it is,
 and a workaround.

 All you said is "pay me to implement the feature". You did not expain why
 you need money as project is free. You also did not explain why you cannot
 implement just a feature, which will be disabled by default (so lamers
 don't have to worry about).
 {{{
 0140873A  /$  83EC 2C       SUB ESP,2C
 0140873D  |.  FF15 E4AF1303 CALL DWORD PTR DS:[<&KERNEL32.IsDebugger>;
 |[IsDebuggerPresent
 01408743  |.  85C0          TEST EAX,EAX                             ; |
 01408745  |.  74 4A         JE SHORT xul.01408791                    ; |
 01408747  |.  C74424 10 001>MOV DWORD PTR SS:[ESP+10],1000           ; |
 0140874F  |.  8B4424 30     MOV EAX,DWORD PTR SS:[ESP+30]            ; |
 01408753  |.  894424 14     MOV DWORD PTR SS:[ESP+14],EAX            ; |
 01408757  |.  FF15 ECAE1303 CALL DWORD PTR DS:[<&KERNEL32.GetCurrent>;
 |[GetCurrentThreadId
 0140875D  |.  894424 18     MOV DWORD PTR SS:[ESP+18],EAX            ; |
 01408761  |.  C74424 1C 000>MOV DWORD PTR SS:[ESP+1C],0              ; |
 01408769  |.  8D4424 10     LEA EAX,DWORD PTR SS:[ESP+10]            ; |
 0140876D  |.  894424 0C     MOV DWORD PTR SS:[ESP+C],EAX             ; |
 01408771  |.  C74424 08 040>MOV DWORD PTR SS:[ESP+8],4               ; |
 01408779  |.  C74424 04 000>MOV DWORD PTR SS:[ESP+4],0               ; |
 01408781  |.  C70424 88136D>MOV DWORD PTR SS:[ESP],406D1388          ; |
 01408788  |.  FF15 48B01303 CALL DWORD PTR DS:[<&KERNEL32.RaiseExcep>;
 \RaiseException
 0140878E  |.  83EC 10       SUB ESP,10
 01408791  |>  83C4 2C       ADD ESP,2C
 01408794  \.  C3            RETN
 }}}
 First people must patch JE > JMP.
 {{{
 01D9EE18   .  807C24 2F 00  CMP BYTE PTR SS:[ESP+2F],0
 01D9EE1D   .  74 07         JE SHORT xul.01D9EE26
 01D9EE1F   .  EB 1A         JMP SHORT xul.01D9EE3B
 01D9EE21   >  BB 00000000   MOV EBX,0
 01D9EE26   >  8B4424 34     MOV EAX,DWORD PTR SS:[ESP+34]
 01D9EE2A   .  85C0          TEST EAX,EAX
 01D9EE2C   .  74 2A         JE SHORT xul.01D9EE58
 01D9EE2E   .  8B10          MOV EDX,DWORD PTR DS:[EAX]
 01D9EE30   .  890424        MOV DWORD PTR SS:[ESP],EAX
 01D9EE33   .  FF52 08       CALL DWORD PTR DS:[EDX+8]
 01D9EE36   .  83EC 04       SUB ESP,4
 01D9EE39   .  EB 1D         JMP SHORT xul.01D9EE58
 01D9EE3B   >  C70424 000000>MOV DWORD PTR SS:[ESP],0
 01D9EE42   .  FF15 4CB41303 CALL DWORD PTR DS:[<&ole32.OleSetClipboa>;
 ole32.OleSetClipboard
 }}}
 First line
 {{{
 CMP BYTE PTR SS:[ESP+2F],0
 }}}
 is something like option compare. You can modify next JE to JMP.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16376#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online