[tor-bugs] #16360 [Tor]: tor_main continues after failed crypto_early_init in tor_init

[Tor Bug Tracker & Wiki]

#16360: tor_main continues after failed crypto_early_init in tor_init
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  new
 Priority:  normal        |      Milestone:  Tor: 0.2.7.x-final
Component:  Tor           |        Version:
 Keywords:  026-backport  |  Actual Points:
Parent ID:                |         Points:
--------------------------+------------------------------------
 A typo in the return value from `tor_init` means that if
 `crypto_early_init` fails, `tor_main` can continue running, rather than
 returning with an error value.

 This bug was introduced in commit `d3fb846d8c98` possibly related to
 feature #4900, first released in 0.2.5.2-alpha.

 Given it's a very simple fix, where tor continues to run half-initialised,
 we might want to backport it.

 I'll post a branch very soon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16360>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online