[tor-bugs] #16276 [Onionoo]: bug in onionoo's family set detection

[Tor Bug Tracker & Wiki]

#16276: bug in onionoo's family set detection
-----------------------------+-----------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  major        |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------

Comment (by cypherpunks):

 Replying to [comment:12 karsten]:
 > Regarding the bug, Onionoo indeed copies whatever relays define in their
 server descriptors to the details document without performing any checks.
 It's only the family parameter that is checked for actually mutual family
 relations.
 >

 > As for the fix, let's start with the easy fix, which means fixing the
 documentation.  How about:
 >
 > "Array of fingerprints or nicknames of relays in the same family as this
 relay '''as reported by the relay'''.  Omitted if empty or if descriptor
 containing this information cannot be found."

 I would prefere something more obvious '''without''' "in the same family
 as this relay".
 Example:
 {{{
 Array of fingerprints or nicknames found in the family line of the relay's
 descriptor. This is basically a copy of the relay's MyFamily torrc
 configuration. Fingerprints and nicknames do not necesarily have a mutual
 (effective) family with this relay.
 }}}

 > As long-term fix, let's think about adding separate field
 "effective_family"

 Looking forward to it!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16276#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online