[tor-bugs] #16013 [Tor]: Assertion ENTRY_TO_CONN(conn)->state == AP_CONN_STATE_CIRCUIT_WAIT failed in circuit_get_open_circ_or_launch at circuituse.c:1835

[Tor Bug Tracker & Wiki]

#16013: Assertion ENTRY_TO_CONN(conn)->state == AP_CONN_STATE_CIRCUIT_WAIT failed
in circuit_get_open_circ_or_launch at circuituse.c:1835
-----------------------------+-------------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  needs_information
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  regression 026-backport
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------

Comment (by nickm):

 I added a log message in commit aab7d666cd51fdccdb735f7fa2c59f93d0c450e9
 that should log a little more info if this error recurs.  To see it,
 reproduce the bug with git master (or with 0.2.7.2-alpha when it's out).

 Looking at the code and the stack trace, I see that we seem to be calling
 circuit_get_open_circ_or_launch() from
 connection_ap_handshake_attach_circuit().  But
 connection_ap_handshake_attach_circuit() already did `
 tor_assert(base_conn->state == AP_CONN_STATE_CIRCUIT_WAIT);`.  So all I
 can figure is that either we're passing a different connection (!?), or
 the state has changed between the start of
 connection_ap_handshake_attach_circuit() and the call to
 circuit_get_open_circ_or_launch().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16013#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online