[tor-bugs] #16343 [Tor]: Address of struct member is always non-NULL in SSL_SESSION_get_master_key in f90a704f1258

Wed Jun 10 14:54:30 UTC 2015

#16343: Address of struct member is always non-NULL in SSL_SESSION_get_master_key
in f90a704f1258
--------------------+------------------------------------
 Reporter:  teor    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.7.x-final
Component:  Tor     |        Version:  Tor: 0.2.7.1-alpha
 Keywords:  clang   |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 clang complains that the address of a struct member is always non-NULL in
 SSL_SESSION_get_master_key in commit f90a704f1258.

 Instead, I suggest we check `SSL_SESSION *s` and `uint8_t *out` are non-
 NULL right before we dereference them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16343>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online