[tor-bugs] #16288 [Tor]: The open file limit is not checked before calling tor_accept_socket_nonblocking()

[Tor Bug Tracker & Wiki]

#16288: The open file limit is not checked before calling
tor_accept_socket_nonblocking()
-------------------------+--------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  026-backport
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by nickm):

 I think the windows issue still needs fixing.  If you set "errno = EMFILE"
 on windows, then WSAGetLastError won't detect it on the socket; instead,
 it will detect whatever the last socket error is.

 I think that the solution might be what's in bug16288_027_02_nm.  Seem
 okay to you?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16288#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online