[tor-bugs] #4862 [Tor]: Consider disabling dynamic intro point formula (numerology)

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jun 9 13:25:49 UTC 2015


#4862: Consider disabling dynamic intro point formula (numerology)
-------------------------+-------------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  major    |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  needs-proposal, tor-hs,
   Resolution:           |  027-triaged-1-in, SponsorR
Actual Points:           |  Parent ID:
       Points:           |
  medium/large           |
-------------------------+-------------------------------------------------

Comment (by asn):

 Oh my, complex branch!

 One small question for now:

 - I see you are decrementing `n_intro_points_established` in
 `remove_invalid_intro_points()`. I'm wondering if this decrement always
 matches with a previous increment.

   I see we are only incrementing that counter in
 `rend_service_intro_established()` when we receive an `INTRO_ESTABLISHED`
 cell. What happens if the circuit dies before we receive an
 `INTRO_ESTABLISHED` cell, but after we add it to the `intro_nodes`
 smartlist? In that case, the counter will be extra decremented, right?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4862#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list