[tor-bugs] #16288 [Tor]: The open file limit is not checked before calling tor_accept_socket_nonblocking()

[Tor Bug Tracker & Wiki]

#16288: The open file limit is not checked before calling
tor_accept_socket_nonblocking()
-------------------------+--------------------------------
     Reporter:  dgoulet  |      Owner:
         Type:  defect   |     Status:  needs_revision
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  026-backport
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 * max_file_descriptors starts out at 0; I think it should start somewhere
 much much higher, so that it can take effect _before_ we call nonblocking
  * We should call max_file_descriptors "max_sockets" instead, right?  We
 apply this limit to sockets, not fds.
  * Windows handles socket errno differently; they don't go in errno and
 our code doesn't look in errno. They use WSAGetLastError() instead.
  * It isn't safe to call tor_socket_errno() on two sockets in succession
 as you do for news and conn->s in connection_handler_listener_read().
 Remember, on Unix it's mostly just an alias for errno.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16288#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online