[tor-bugs] #16276 [Onionoo]: bug in onionoo's family set detection

[Tor Bug Tracker & Wiki]

#16276: bug in onionoo's family set detection
-----------------------------+-----------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  major        |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------

Comment (by leeroy):

 So I was in the area, and saw this ticket update, so I thought I would
 investigate. Is it possible you're not using the family parameter, but
 rather looking at the details document itself? Onionoo's protocol page
 describes the family parameter as a filter which: `Return only the relay
 whose fingerprint matches the parameter value and
 all relays that this relay has listed in its family by fingerprint and
 that in turn have listed this relay in their family by fingerprint.`

 Which is different from the details document: `Array of fingerprints or
 nicknames of relays in the
 same family as this relay.
 Omitted if empty or if a descriptor containing this information cannot be
 found.
 `

 The details document is a representation of the descriptor published.
 Which means it will match whatever is published by the OR, even if that
 includes an incomplete family declaration. You'll recall that such a
 situation is possible on tor's network. So if you look at the details
 page, for example by using the fingerprint, you'll see exactly what the OR
 declared in it's last published descriptor.

 The index, which makes the filtering of data possible, is computed in
 [https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/server/NodeIndexer.java
 NodeIndexer]. If all this is true, the question(s) still remains, should
 details documents include the ''effective'' family or the ''declared''
 family ? Should the protocol description, or the details document
 (produced by Atlas) be re-worded ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16276#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online