[tor-bugs] #15607 [Tor]: Tor log dates imprecise

[Tor Bug Tracker & Wiki]

#15607: Tor log dates imprecise
------------------------+--------------------------
     Reporter:  atagar  |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.???
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------

Comment (by rl1987):

 {{{
 18:39 < rl1987> oh, and there was #15607
 18:40 < rl1987> maybe we should reach a decision on that?
 18:40 -!- cicada [~cicada_33 at 80.82.64.92] has joined #tor-dev
 18:41 < armadev> putting a year in every log line seems like crazy talk
 18:41 < armadev> i was always confused about why nyx tried to parse the
 log
                  files anyway
 18:42 < armadev> i could be convinced about a config option, "make logs
                  readable by nyx", off by default, and then nyx turns it
 on
 18:42 < armadev> but if nyx is going to do that, maybe it should just
 listen
                  for log controller events and be done with it
 18:42 -!- cicada [~cicada_33 at 0001fdfc.user.oftc.net] has quit []
 18:42 < armadev> i guess the use case is to present your logs from disk to
 you,
                  even before nyx started
 18:44 < rl1987> then, wontfix?
 18:45 < armadev> rl1987: i haven't read the bug
 18:48 < atagar> armadev: 'i was always confused about why nyx tried to
 parse
                 the log files anyway' => Nyx emits its own log messages,
 and I
                 read the date because I order the overall log by the
                 timestamps. That, and nyx groups messages by date with a
                 border. Tor lacking the year isn't an overly big whoop,
 but
                 it's something I need to hack around and introduces errors
 with
                 edge cases like leap years.
 18:49 < armadev> i wonder if tor should put a year at the top of its log
 when
                  it opens it?
 18:49 < armadev> (is this related?)
 18:49 < atagar> Sure, for my purposes think that would do the trick.
 18:49 < armadev> i am not against admitting the year
 18:49 < armadev> i just don't want it in every line
 18:51 < atagar> Understandable. It's very strange that tor omits it (first
                 application logs I've seen that does that), but it makes
 sense
                 for cutting down on noise if you don't care about long
 term
                 logging.
 18:51 < atagar> Personally I'd opt for emitting the year on stdout but
                 including it in the log file, but just my two cents.
 18:52 < atagar> oops, s/emitting/omitting
 18:55 < rl1987> atagar, armadev: so, we need to log a full timestamp every
 time
                 we start a new log file, but log timestamps without year
 for
                 every regular log entry?
 18:57 < rl1987> can we agree on this?
 19:02 < armadev> rl1987: works for me. it doesn't even need to be every
 time we
                  open a new log file. it could be whatever log line tor
 puts
                  into the log file first. i hope there is something like
 that
                  already, for existing log files, where tor writes its
 version
                  and stuff first.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15607#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online