[tor-bugs] #16639 [Tor Browser]: Check for Updates menu item can cause update failure

[Tor Bug Tracker & Wiki]

#16639: Check for Updates menu item can cause update failure
----------------------------+----------------------------------------------
     Reporter:  mikeperry   |      Owner:  mcs
         Type:  defect      |     Status:  needs_review
     Priority:  major       |  Milestone:
    Component:  Tor         |    Version:
  Browser                   |   Keywords:  TorBrowserTeam201507R, tbb-5.0a4
   Resolution:              |  Parent ID:
Actual Points:              |
       Points:              |
----------------------------+----------------------------------------------
Changes (by mcs):

 * keywords:  TorBrowserTeam201507, tbb-5.0a4 => TorBrowserTeam201507R,
     tbb-5.0a4
 * status:  new => needs_review


Comment:

 It seems that we need to check the update state and open the prompt in the
 correct mode.  Here is a fix:
 https://gitweb.torproject.org/user/brade/torbutton.git/log/?h=bug16639-01

 Please review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16639#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online