[tor-bugs] #16424 [metrics-lib]: Add code to eventually support .xz compressed tarballs

[Tor Bug Tracker & Wiki]

#16424: Add code to eventually support .xz compressed tarballs
-----------------------------+--------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by karsten):

 Replying to [comment:28 leeroy]:
 > Karsten, I just did clone this branch.
 >
 > - You're using the archive entryName() not the parsed file name.
 Previously it was the parsed entry name minus the relative path.

 Note that there are two different file names.  We're setting the
 ''descriptor file'' name to the full path obtained from `entry.getName()`,
 and we're using the parsed entry name minus the relative path when we pass
 a file name to the descriptor parser.  Again, I think I changed back what
 you changed beforehand.

 > - You changed the archive stream helper to return a concrete tar archive
 input stream, previously it only returned a tar archive input stream if it
 was possible, and would return null otherwise. This now means an archive
 will return a non-null reference even if opening the archive failed. Which
 means operating on it's contents will eventually fail when it shouldn't
 have been processed.

 I did change that helper method, but I don't think it would ever return a
 non-null reference in case of a failure.  If there was an IOException that
 would be thrown and caught by the caller.  I don't see what else could go
 wrong there, but maybe I'm just not seeing it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16424#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online