[tor-bugs] #16424 [metrics-lib]: Support parsing of .xz compressed tarballs

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Jul 18 14:31:49 UTC 2015


#16424: Support parsing of .xz compressed tarballs
-----------------------------+----------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------

Comment (by karsten):

 I wonder if we're talking about two different things.  Let me paste a
 partial diff of build.xml:

 {{{
 @@ -11,6 +11,7 @@
        <include name="commons-codec.jar"/>
        <include name="commons-compress.jar"/>
        <include name="junit4.jar"/>
 +      <include name="xz.jar"/>
      </fileset>
    </path>
 }}}

 This change must go in, or the code won't compile, right?  (I didn't test
 this branch yet.)  I'm not arguing against this change.

 {{{
 @@ -41,7 +42,13 @@
    </target>
    <target name="jar" depends="compile">
      <jar destfile="${jarfile}"
 -         basedir="${classes}"/>
 +         basedir="${classes}">
 +      <zipgroupfileset dir="/usr/share/java">
 +        <include name="commons-codec.jar"/>
 +        <include name="commons-compress.jar"/>
 +        <include name="xz.jar"/>
 +      </zipgroupfileset>
 +    </jar>
    </target>
    <target name="test" depends="compile">
      <javac destdir="${classes}"
 }}}

 This is the change I'd rather not want to merge for the reasons stated
 above.

 Does that resolve any confusion?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16424#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list