[tor-bugs] #16424 [metrics-lib]: Support parsing of .xz compressed tarballs

[Tor Bug Tracker & Wiki]

#16424: Support parsing of .xz compressed tarballs
-----------------------------+----------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------

Comment (by karsten):

 Replying to [comment:7 leeroy]:
 > Thank you for the feedback. Please do be picky about whitespace and
 style.

 Thanks for understanding!

 > Yes I will do as you suggest about the repository. The only reason I
 haven't sooner is due to using trac as a sort of backup.

 Oh. :)

 > Java 7 is additive wrt the api. Any 1.6 based applications will compile
 fine. But yes I can remove it. metrics-lib is exactly the kind of
 application that benefits from 1.7...

 I could imagine switching to 1.7 soon, I'd just prefer merging this patch
 even sooner.  New ticket?

 > Which file are you referring to? xz.jar (libxz)? it '''is''' a required
 include. It's just done by libcommons-compress normally. This include
 makes the dependency clear. xz support is an '''optional''' download of
 libcommons-compress. This include detects it's absence.

 Yes, the include is fine.  I mean the `<zipgroupfileset/>` element.

 > Is it the other two includes, commons-codec.jar, and commons-
 compress.jar? They are also required includes for metrics-lib
 functionality. The only reason it hasn't failed sooner is because you only
 use it in onionoo (and onionoo does the include for you). For metrics-lib
 to be general these includes are needed...

 Well, it would work if Onionoo (and others) would include `xz.jar`
 themselves, even without this change to the build file, right?  This is
 also something we could change soon but which shouldn't be related to
 adding .xz parsing support.  For example, one thing I'm concerned about is
 that we're using different `commons-codec.jar` versions for building
 `descriptor.jar` and as a dependency in Onionoo.  It could well be that
 this concern is not valid, but I'd want to think more about that and any
 other implications when I have more time.  New ticket?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16424#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online