[tor-bugs] #16299 [Stem]: Stem unit test failure for test_compare_flags

[Tor Bug Tracker & Wiki]

#16299: Stem unit test failure for test_compare_flags
------------------------+--------------------------
     Reporter:  atagar  |      Owner:  atagar
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:
    Component:  Stem    |    Version:
   Resolution:          |   Keywords:  testing
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------

Comment (by cypherpunks):

 Replying to [comment:7 atagar]:
 > Ahh, think this might be confusion because of the method name I chose.
 Calling get_vote() kicks off a request and provides a
 [https://stem.torproject.org/api/descriptor/remote.html#stem.descriptor.remote.Query
 Query instance], and run() blocks until you get the result.
 After rereading the code i see queries start on initialization. I missed
 that the last time and thought `run()` starts the queries.

 Because of this flaw you can disregard the first patch. The second patch
 uses an ordered dictionary which ensures `queries.items()` returns
 key/value pairs in the same order they were added. The same order meaning
 the order in which the authorities are returned by `get_authorities`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16299#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online