[tor-bugs] #16515 [Tor]: tor_open_cloexec only uses the sandbox when O_CLOEXEC is defined

[Tor Bug Tracker & Wiki]

#16515: tor_open_cloexec only uses the sandbox when O_CLOEXEC is defined
----------------------+------------------------------------
 Reporter:  teor      |          Owner:
     Type:  defect    |         Status:  new
 Priority:  major     |      Milestone:
Component:  Tor       |        Version:  Tor: 0.2.3.1-alpha
 Keywords:  backport  |  Actual Points:
Parent ID:            |         Points:
----------------------+------------------------------------
 In `tor_open_cloexec`, the `sandbox_intern_string` call is inside `#ifdef
 O_CLOEXEC`.

 This means that we only use the sandbox if O_CLOEXEC is defined, which I
 doubt is the desired behaviour.

 Bug from 0.2.3.1-alpha.
 Fix branch coming soon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16515>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online