[tor-bugs] #16276 [Onionoo]: bug in onionoo's family set detection
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jul 6 14:48:42 UTC 2015
#16276: bug in onionoo's family set detection
-----------------------------+--------------------------
Reporter: cypherpunks | Owner:
Type: enhancement | Status: needs_review
Priority: normal | Milestone:
Component: Onionoo | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-----------------------------+--------------------------
Comment (by karsten):
Replying to [comment:32 leeroy]:
> It breaks the unit tests but not a huge deal until you're sure you want
to commit.
Yes, I noticed that too but didn't push the local fix yet. I just did
that, together with a few other minor fixes. Thanks for pointing this
out!
> In your fixup you add back some of what was removed but you don't add
back setFamilyFingerprints, which means getFamilyFingerprints will always
return null. If your intention is to support both families fully you'll
need to add back the setter and set it from NodeStatus (like before).
That should work, because Gson would access that attribute directly
without using its setter.
Okay, I didn't hear any major concerns about this plan, so I'll proceed:
Onionoo mirror at https://onionoo.thecthulhu.com/ will soon (1 hour from
now?) have an `"effective_family"` field.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16276#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list