[tor-bugs] #16480 [Tor]: connection_write_to_buf: indirect recursion for CONN_TYPE_CONTROL

[Tor Bug Tracker & Wiki]

#16480: connection_write_to_buf: indirect recursion for CONN_TYPE_CONTROL
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by arma):

 Replying to [comment:1 cypherpunks]:
 > Do we really need to flush it such way for control port:
 > {{{
 >                conn->outbuf_flushlen-len < 1<<16 &&
 >                conn->outbuf_flushlen >= 1<<16
 > }}}
 > what is profit, when it happens, why it happens?

 Oh, oh, I know this one.

 Back in the day, Vidalia would ask a control port question with a really
 big answer (like "give me all the microdescs"), and Tor would put the
 answer on its control port, but then the outbuf would get too big, and the
 "is there too much on the outbuf" check would trigger, killing the
 connection.

 Maybe enough of the rest of the code has changed that this bad behavior
 wouldn't happen anymore? Or maybe it is just like it was?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16480#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online