[tor-bugs] #14216 [Tor]: We only "optimistically retry connections" once if we have other bridges descs

[Tor Bug Tracker & Wiki]

#14216: We only "optimistically retry connections" once if we have other bridges
descs
------------------------+--------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-bridge, 025-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------------

Comment (by sysrqb):

 Replying to [comment:5 sysrqb]:
 > As far as I can tell, we only set bad_since on a bridge's entry_guard_t
 when we used it and then it was remove from the configuration, so it's
 marked as bad/unlisted.

 We also set it on bridges for which we haven't received a descriptor, but
 I think that's ok because we wouldn't want to use it anyway. Also, maybe
 we set it if the bridge falls into the ExcludeNodes.

 So, i have two branches, one which uses arma's patch and another which
 also checks !e->bad_since. I'm not sure if the latter is more useful.

 arma, nickm, please modify the patch and changelog until your happy with
 them.

 bug14216
 bug14216_bad_since

 https://git.torproject.org/user/sysrqb/tor.git

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14216#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online