[tor-bugs] #14422 [Tor Browser]: Fix makefile rules to make+hash incrementals by default

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jan 29 15:28:59 UTC 2015


#14422: Fix makefile rules to make+hash incrementals by default
---------------------------+-----------------------------------------------
     Reporter:  mikeperry  |      Owner:  tbb-team
         Type:  defect     |     Status:  needs_review
     Priority:  normal     |  Milestone:
    Component:  Tor        |    Version:
  Browser                  |   Keywords:  tbb-gitian, TorBrowserTeam201501R
   Resolution:             |  Parent ID:
Actual Points:             |
       Points:             |
---------------------------+-----------------------------------------------

Comment (by gk):

 Replying to [comment:6 mcs]:
 > I am not a big fan of "soft failures" such as emitting a warning instead
 of stopping (easy to miss).

 Me neither. But I don't want to make it harder for anonymous builder and
 doing less steps during the release cycle can't hurt. So, I am in favor of
 having the warning in case someone does not have all the things needed for
 the incrementals.

 Downloading and using the other MARs + getting reproducible MAR files in
 return that match ours might need more thinking anyway due to the
 signatures which start to get included. I think this complication can be
 handled in the future if need arises, in a different bug.

 > But I am also not one of the people who produces our official builds, at
 least not at the moment.

 If you want, just say so. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14422#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list