[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_review
         Type:  task     |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-guard, tor-relay, prop237
   Resolution:           |  026-triaged-1
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by sysrqb):

 * status:  needs_revision => needs_review


Comment:

 thanks for the reviews! These issues should be resolved now.

 I also tested this branch in mixed chutney nets with 0.2.5 - one network
 had five authdirs running this patch and another network had three 0.2.5
 and two authdirs running this patch, both nets had a mix of clients and
 relays running 0.2.5 and this patch. No warning during voting and flags
 were assigned correctly.

 When all five dirauths ran this patch, all relays which declared
 "tunnelled-dir-server" were assigned v2dir, regardless of dirport
 configuration and patched clients chose them and successfully used them.
 0.2.5 clients only chose the dirauths and relays with advertised dirports.

 In the net with three 0.2.5 dirauths and two patched dirauths, the relays
 were assigned v2dir only if they had an open dirport. Patched relays and
 clients fellback to the current functionality - only choosing dircaches
 with open dirports.

 There are two branches. feature12538_rebased_2 has subsequent
 changes/corrections as new commits. feature12538_rebased_2_fixup squashed
 and fixed up the changes with the original commits. Both are rebased and
 apply cleanly on master.

 https://git.torproject.org/user/sysrqb/tor.git

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online