[tor-bugs] #14266 [Tor]: Make address mapping conditional on having the particular address mapping types enabled.

[Tor Bug Tracker & Wiki]

#14266: Make address mapping conditional on having the particular address mapping
types enabled.
------------------------------------+----------------------------------
 Reporter:  nickm                   |          Owner:
     Type:  defect                  |         Status:  new
 Priority:  normal                  |      Milestone:  Tor: unspecified
Component:  Tor                     |        Version:
 Keywords:  tor-client refactoring  |  Actual Points:
Parent ID:                          |         Points:
------------------------------------+----------------------------------
 It might be simpler to understanding the logic for address mapping if each
 type of mapping were conditional on having the right thing enabled.  For
 example:

    * DNS mapping could be conditional on client-side DNS caching (bad
 idea!) being enabled.
    * Automap mapping could be conditional on AutomapHostsOnResolve being
 enabled.
    * TrackExit mapping could be conditional on having TrackHostExits being
 set.
    * MapAddress mappings could be applied only if MapAddress is set.
    * MAPADDRESS mappigns could be applied only if the controller
 MAPADDRESS command has called.

 Would this make the logic more clear?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14266>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online