[tor-bugs] #9321 [Tor]: Load balance right when we have higher guard rotation periods

[Tor Bug Tracker & Wiki]

#9321: Load balance right when we have higher guard rotation periods
-------------------------+-------------------------------------------------
     Reporter:  arma     |      Owner:
         Type:  project  |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  needs-proposal, tor-auth, tor-
Actual Points:           |  client, 026-triaged-1
       Points:           |  Parent ID:  #11480
-------------------------+-------------------------------------------------

Comment (by asn):

 Replying to [comment:34 teor]:
 > I have the following unit tests fail on an OS X 10.9.5 i386 build, but
 not on the x86_64 build:
 > {{{
 > guardfraction/parse_guardfraction_file_bad: [forking]
 >   FAIL src/test/test_guardfraction.c:116: assert(retval == 2): -1 vs 2
 >   [parse_guardfraction_file_bad FAILED]
 > guardfraction/parse_guardfraction_file_good: [forking]
 >   FAIL src/test/test_guardfraction.c:218: assert(retval == 1): -1 vs 1
 >   [parse_guardfraction_file_good FAILED]
 > }}}
 > Anything in particular I should look for to diagnose, asn?

 Yes, it would be great if you could diagnose this.

 What I would do is go to `dirserv_read_guardfraction_file_from_str()` and
 add some `printf` in the places where it can return -1. IIRC, that's all
 the places where `goto done;` is called. Then run the tests again, and see
 which `printf` triggers to see what causes the error.



 IIRC, -1 can be returned if `config_get_lines()` fails, or if the date was
 wrong, or if the version was wrong. I'm wondering what's the case here for
 i386.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9321#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online