[tor-bugs] #9701 [Tor Browser]: Prevent TorBrowser from creating clipboardcache turds

[Tor Bug Tracker & Wiki]

#9701: Prevent TorBrowser from creating clipboardcache turds
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  cypherpunks            |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-disk-leak, interview, tbb-
  Browser                |  firefox-patch, TorBrowserTeam201501R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Replying to [comment:31 michael]:
 > I used the accessor so that the mPrivateData type could be internally
 changed in a future FF release (typical raison d'etre for accessors,) but
 either way is fine. If we have a convention of direct member manipulation
 I'll change the logic to match.
 >
 > Do we/should I?

 I do not know that we have a policy, but in this case things are simple
 enough (and you are in the same class), so direct access seems OK to me.
 And it will simplify the patch a little since you can avoid some error
 checking that is not needed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9701#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online