[tor-bugs] #14071 [metrics-lib]: BlockingIteratorImpl.hasNext waits forever

[Tor Bug Tracker & Wiki]

#14071: BlockingIteratorImpl.hasNext waits forever
-----------------------------+----------------------
     Reporter:  iwakeh       |      Owner:  karsten
         Type:  defect       |     Status:  accepted
     Priority:  blocker      |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------

Comment (by karsten):

 Wow, good catch!  Want to try out
 [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-14071 my branch task-14071]?  I'm particularly
 interested what runtime exception that was, because we should fix that
 regardless of surrounding things with `try`.

 Regarding logging, I agree that we should have that.  But for now, I'd say
 write to stderr if something really bad happens.  (Like a runtime
 exception in the descriptor reader thread...)

 Regarding the suggested event mechanism, I'd say let's just write a new
 DescriptorReader interface and implementation class, and deprecate the
 existing interface.  The current interface has some parts I'd want to get
 rid of anyway: all configuration should happen in a builder class, and
 reading/writing the parse history file shouldn't be done by the reader at
 all.

 Sorry for taking so long to respond.  And thanks a lot for investigating
 this!  I'm curious to learn what the exception was.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14071#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online