[tor-bugs] #13111 [Tor]: Tor fails to start if onion keys are zero length

[Tor Bug Tracker & Wiki]

#13111: Tor fails to start if onion keys are zero length
-------------------------+--------------------------------
     Reporter:  ioerror  |      Owner:  teor
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-relay
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------
Changes (by teor):

 * cc: nickm (added)
 * keywords:  tor-relay lorax => tor-relay
 * status:  needs_revision => needs_review


Comment:

 Nick, I've updated the existing branch to include the following tests:
 * check tor launches and overwrites empty files with new keys (bug fix)
 * check tor creates new keys for missing files (existing behaviour)
 * check tor doesn't overwrite existing, non-empty keys (existing
 behaviour)

 This is included in `make check-local`

 I've also merged the latest git, including merging a single line which was
 changed in this branch and in the latest git (origin added an argument,
 this branch changed an argument and added a comment). Will this need a
 rebase?


 Branch: bug13111-empty-key-files-fn-empty
 Repository: ​​​​https://github.com/teor2345/tor.git

 (However, I'm still not ready for new work yet. I still have to do #14067
 + #13401.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13111#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online