[tor-bugs] #13079 [Tor Browser]: environment variable to skip TorButton control port verification

[Tor Bug Tracker & Wiki]

#13079: environment variable to skip TorButton control port verification
-------------------------+-------------------------------------------------
     Reporter:  proper   |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-torbutton,
  Browser                |  TorBrowserTeam201501R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by proper):

 Replying to [comment:8 mcs]:
 > The patch looks OK.

 Great!

 > The only question I have is whether we should check for a value of "1"
 in the TOR_SKIP_CONTROLPORTTEST env variable (rather than just checking
 for existence).

 Replying to [comment:10 gk]:
 > Personally, I think having just the existence of the environment
 variable is enough.

 Yes, indeed. Why use more code than required.

 > That said I don't mean to imply that we should change the way Tor
 Launcher does this. But I'd like to keep the related Torbutton code as-is
 and to avoid mixing both styles.

 For env var `TOR_SKIP_LAUNCH` (in file `tl-util.jsm`), tor-launcher does
 check the value of the env var.

 (Line: `return ("1" != env.get(kEnvSkipLaunch));`)

 We we agree it's unnecessary?

 What about this...

 * This patch using the simpler method (only env.exists check) is merge
 able.
 * And create a follow up ticket to simplify the other env var checks?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13079#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online