[tor-bugs] #13267 [Onionoo]: escaped forward slashes in contact info
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Feb 25 14:10:38 UTC 2015
#13267: escaped forward slashes in contact info
---------------------------+--------------------------
Reporter: Sebastian | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Onionoo | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
---------------------------+--------------------------
Changes (by karsten):
* status: new => needs_review
Comment:
While working on a fix, I discovered that we introduced a related bug a
few months ago. Right now we're not only escaping `/` wrong, but also
`'`...
Here's the contact line currently returned for the sample relay mentioned
above:
{{{
"contact":"2048R\\/DE500B3E Peter Lebbing <tormail at (this router\\'s
nickname) dot com>"
}}}
Please find
[https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-13267
my branch task-13267] with two commits, one to fix that recently
introduced bug and one to stop escaping `/`.
Note that I'm ignoring my own advice by handling old files and new files
the same. At least that didn't break horribly in local tests. I'm going
to deploy this branch on the mirror now to see if it works.
I'd like to merge to master before the weekend, if possible. Review much
appreciated.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13267#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list