[tor-bugs] #9321 [Tor]: Load balance right when we have higher guard rotation periods

[Tor Bug Tracker & Wiki]

#9321: Load balance right when we have higher guard rotation periods
-------------------------+-------------------------------------------------
     Reporter:  arma     |      Owner:
         Type:  project  |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  needs-proposal, tor-auth, tor-
Actual Points:           |  client, 026-triaged-1, unfrozen, nickm-review
       Points:           |  Parent ID:  #11480
-------------------------+-------------------------------------------------

Comment (by nickm):

 8f4563048534cddcc67e34de76a3935dfdaaf9c6

   - document in guardfraction_line_apply that vote_routerstatuses must be
     sorted.

 ef3bec7f62c901ec62445703a16177b49df397e1

   - enougn -> enough

 7b6eed0320b4955d9b252adb2833c7cbabf6523a

   - This is going to sound a bit silly, but I think that we should be
 using
     lround rather than cast-to-int to convert the float to int in
     guard_get_guardfraction_bandwidth, and we should be using subtraction
 to
     get non_guard_bw, so that non_guard_bw + guard_bw == orig_bandwidth

 769246b014f98b146a636acd06febced1fc72940

   - In update_total_bandwidth_weights(), I am not 100% sure that the
 comment
     matches the code.  Are you?  For example, I don't see anything in the
     comment about *M += default_bandwidth.

 2eaa9b7c778d8314dbe341b56da67f9a641908ee:

   - An empty or missing file should not keep us from checking the file
 again
     later, shoult it?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9321#comment:49>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online