[tor-bugs] #14859 [Onionoo]: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new format

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Feb 16 15:32:47 UTC 2015


#14859: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new
format
-------------------------+--------------------------
     Reporter:  karsten  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------

Comment (by karsten):

 Oh wow, looks like ISO-8859-1 was not the right charset at all.  The
 special characters you mention are all in
 [http://en.wikipedia.org/wiki/ISO/IEC_8859-9 ISO-8859-9], not in
 [http://en.wikipedia.org/wiki/ISO/IEC_8859-1 ISO-8859-1].  Oops!  Turns
 out MaxMind uses UTF-8 for their files.

 Please take a look at the latest commit I pushed to the branch mentioned
 above.  It changes character encoding and adds test cases for the Turkish
 cities you mentioned.

 Anything else we should test?  If not, are you ready for these commits to
 be merged into master?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14859#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list