[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_revision
         Type:  task     |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-guard, tor-relay, prop237,
   Resolution:           |  026-triaged-1, sebastian-review
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by sysrqb):

 Replying to [comment:40 Sebastian]:
 > should the "implies" be implying?
 Yes, fixed.

 Replying to [comment:41 Sebastian]:
 > Ok, for a bunch of stuff you're using free() instead of tor_free().
 Fixed

 Replying to [comment:42 Sebastian]:
 > I'm concerned about the routerlist_free_all() call because what happens
 with the node_t things that we created along with it? Just calling
 nodelist_free_all() would be a workaround, but I think this may have
 exposed a deeper problem with routerlist_free_all(). Hrm.
 I added the workaround. Good catch! After thinking about this some more,
 if it were the case where routerlist_free_all() were called at any other
 time, excluding its call during cleanup prior to exit and in tests, I
 wonder if we should explicitly call any other _free_all(), such as for the
 microdescs. At this point, I don't *think* we need to because I don't see
 any other dangling pointers remaining after calling routerlist_free_all()
 and nodelist_free_all(). The microdesc referenced by the node_t should
 still be ref'd in the  microdesc cache, and the routerstatus should still
 be ref'd in the latest consensus. Is this not the case in some situations?

 Thanks for the review, Sebastian!

 Rebased on master and pushed the changes:
 feature12538_rebased_4
 feature12538_rebased_4_fixup

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online