[tor-bugs] #6411 [Tor]: Adding hidden services through control socket

[Tor Bug Tracker & Wiki]

#6411: Adding hidden services through control socket
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  yawning
  kevinevans             |     Status:  accepted
         Type:           |  Milestone:  Tor: unspecified
  enhancement            |    Version:  Tor: 0.2.3.19-rc
     Priority:  normal   |   Keywords:  hidden-service control maybe-
    Component:  Tor      |  proposal tor-hs globalleaks-wants
   Resolution:           |  Parent ID:  #8993
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by yawning):

 * owner:   => yawning
 * status:  needs_revision => accepted


Comment:

 Ok, I started poking at this, loosely based off the original patch.  Not
 quite done yet, but getting there (as in, "I need to backfill a bunch of
 XXX error logging/handling cases, but the core changes should be there",
 at least for the `ADD_EPH_HS` command).

 Notes so far:
  * The tentative commands are now `ADD_EPH_HS` and `DEL_EPH_HS`.
  * The original patch has more things that are wrong:
    * Happy fun times on  config reload if more than one HS added via the
 control port.
    * It leaves a few copies of the private key left splattered on the
 heap.
  * I'm not sure what the behavior for ephemeral hidden services should be
 on a reload.  My patch currently discards them all, since that's the easy
 thing to do, but preserving them is also possible.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online