[tor-bugs] #14819 [Tor]: Thread refactoring breaks linking with --disable-threads

[Tor Bug Tracker & Wiki]

#14819: Thread refactoring breaks linking with --disable-threads
--------------------+------------------------------------
 Reporter:  teor    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  major   |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor     |        Version:  Tor: 0.2.6.2-alpha
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 The recent refactoring (?) of the threads code appears to break linking
 with `./configure --disable-threads` on OS X 10.10 with clang-3.7 (git,
 MacPorts).
 {{{
   CCLD     src/or/tor
 Undefined symbols for architecture x86_64:
   "_tor_cond_wait", referenced from:
       _worker_thread_main in libor.a(workqueue.o)
   "_spawn_func", referenced from:
       _threadpool_new in libor.a(workqueue.o)
   "_tor_cond_signal_all", referenced from:
       _threadpool_queue_update in libor.a(workqueue.o)
   "_tor_cond_uninit", referenced from:
       _tor_cond_free in libor.a(compat_threads.o)
   "_tor_cond_init", referenced from:
       _tor_cond_new in libor.a(compat_threads.o)
       _threadpool_new in libor.a(workqueue.o)
   "_tor_get_thread_id", referenced from:
       _tor_set_openssl_thread_id in libor-crypto.a(crypto.o)
       _set_main_thread in libor.a(compat_threads.o)
       _in_main_thread in libor.a(compat_threads.o)
   "_tor_mutex_init_nonrecursive", referenced from:
       _tor_mutex_new_nonrecursive in libor.a(compat_threads.o)
       _threadpool_new in libor.a(workqueue.o)
   "_tor_mutex_uninit", referenced from:
       _clean_up_backtrace_handler in libor.a(backtrace.o)
       _tor_mutex_free in libor.a(compat_threads.o)
       _threadpool_new in libor.a(workqueue.o)
   "_tor_mutex_init", referenced from:
       _init_logging in libor.a(log.o)
       _configure_backtrace_handler in libor.a(backtrace.o)
       _tor_mutex_new in libor.a(compat_threads.o)
       _replyqueue_new in libor.a(workqueue.o)
   "_tor_mutex_acquire", referenced from:
       _logv in libor.a(log.o)
       _tor_log_update_sigsafe_err_fds in libor.a(log.o)
       _tor_log_get_logfile_names in libor.a(log.o)
       _logs_free_all in libor.a(log.o)
       _add_stream_log in libor.a(log.o)
       _logs_set_domain_logging in libor.a(log.o)
       _add_temp_log in libor.a(log.o)
       ...
   "_tor_mutex_release", referenced from:
       _logv in libor.a(log.o)
       _tor_log_update_sigsafe_err_fds in libor.a(log.o)
       _tor_log_get_logfile_names in libor.a(log.o)
       _logs_free_all in libor.a(log.o)
       _add_stream_log in libor.a(log.o)
       _logs_set_domain_logging in libor.a(log.o)
       _add_temp_log in libor.a(log.o)
       ...
   "_tor_cond_signal_one", referenced from:
       _threadpool_queue_work in libor.a(workqueue.o)
   "_tor_threads_init", referenced from:
       _tor_main in libtor.a(main.o)
 ld: symbol(s) not found for architecture x86_64
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 make[1]: *** [src/or/tor] Error 1
 make: *** [all] Error 2
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14819>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online