[tor-bugs] #14798 [Tor]: Avoid calling SMARTLIST_FOREACH on a NULL smartlist in tests

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Feb 8 12:51:29 UTC 2015


#14798: Avoid calling SMARTLIST_FOREACH on a NULL smartlist in tests
--------------------+------------------------------------
 Reporter:  teor    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor     |        Version:  Tor: 0.2.6.2-alpha
 Keywords:  clang   |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 Two of the test functions could possibly call SMARTLIST_FOREACH on a NULL
 smartlist.

 This branch fixes the issue:

 '''Repository:''' ​​​https://github.com/teor2345/tor.git
 '''Branch:''' avoid-NULL-smartlist-foreach

 Check if each smartlist is NULL before calling SMARTLIST_FOREACH on it.

 Bug discovered by the clang static analyzer.
 Apple clang 600.0.56 (LLVM 3.5svn) on x86_64-apple-darwin14.1.0.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14798>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list