[tor-bugs] #14478 [Tor]: Zero length keys test improvements

[Tor Bug Tracker & Wiki]

#14478: Zero length keys test improvements
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by Sebastian):

 I added a branch with some your patches, bug14478 in my repo.

 I haven't added the first idea yet, because of the reservations against
 mktemp followed by rm -rf. Adding a function like Nick suggested would be
 pretty hard, because who knows what kind of files tor will create during
 its lifetime (and some files it even creates and cleans up itself, unless
 it crashes). Nick, would it be OK to do a check "$DATADIR is not empty,
 the directory exists and it is empty as we start the test"?

 I didn't include patch number three, because that seems a little
 unnecessary to me - the switch is deprecated, not removed after all.
 Detecting whether the switch is deprecated or required is difficult, just
 testing the platform isn't enough because one might have a different
 implementation in their path.

 The issue about undefined behaviour I don't quite get. Is one really
 supposed to use -a only with variables? is [ -s $a -a b ] really
 unspecified behaviour?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14478#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online