[tor-bugs] #14741 [Tor]: Cancelling a cpuworker job doesn't decrement the total pending tasks counter

[Tor Bug Tracker & Wiki]

#14741: Cancelling a cpuworker job doesn't decrement the total pending tasks
counter
----------------------+------------------------------------
 Reporter:  dgoulet   |          Owner:
     Type:  defect    |         Status:  new
 Priority:  critical  |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor       |        Version:  Tor: 0.2.6.2-alpha
 Keywords:            |  Actual Points:
Parent ID:            |         Points:
----------------------+------------------------------------
 {{{cpuworker_cancel_circ_handshake()}}} should decrement the
 {{{total_pending_tasks}}} counter if the job was successfully cancelled
 meaning "job" if not NULL.

 This issue has been observed with a fast relay where enough jobs were
 cancelled making {{{if (total_pending_tasks >= max_pending_tasks)}}}
 always true. There are no ways to decrement the counter without having a
 worker actually completing a job that now can't be queued because we've
 reached the maximum task allowed.

 This makes the relay stop working correctly since no onionskin job can be
 achieved anymore.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14741>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online