[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_review
         Type:  task     |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-guard, tor-relay, prop237
   Resolution:           |  026-triaged-1
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by nickm):

 Re-reviewing based on the `git diff master...` output:

  * directory_fetches_from_authorities() has a semantic change that seems
 wrong in the replacement of me->dir_port.  But now I see that
 dir_server_mode() is not quite the same...

  * In the router.c changes, are we at any risk of having bridges _not_ be
 directory caches?  Bridges all need to be dircaches.

  * Shouldn't the documentation for supports_tunnelled_dir_requests say
 it's also set if `dir_port > 0`?

 Otherwise this looks ok to me now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online