[tor-bugs] #17796 [Tor]: Make crypto_digest_t allocated using minimal memory

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Dec 26 16:42:12 UTC 2015


#17796: Make crypto_digest_t allocated using minimal memory
--------------------+------------------------------------
 Reporter:  nickm   |          Owner:
     Type:  defect  |         Status:  needs_review
 Priority:  Low     |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor     |        Version:
 Severity:  Normal  |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've removed the log code in the switch statement and turned it into a
 hard assert.

 I don't see how that memwipe could write into unallocated memory, though:
 tmpenv is stack-allocated, at the largest size required.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17796#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list