[tor-bugs] #16791 [Tor]: All modules in src/common should have 90-95%+ unit test coverage

[Tor Bug Tracker & Wiki]

#16791: All modules in src/common should have 90-95%+ unit test coverage
---------------------------------+------------------------------------
 Reporter:  nickm                |          Owner:
     Type:  project              |         Status:  new
 Priority:  High                 |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  testing, 028-triage  |  Actual Points:
Parent ID:                       |         Points:  large
  Sponsor:  SponsorS             |
---------------------------------+------------------------------------
Changes (by nickm):

 * severity:   => Normal


Comment:

 Update: here are the current coverage numbers for the unit tests ("make
 check") on common, sorted by percent coverage, on Linux.

 {{{
 cc/sandbox.c.gcov 413 47 10.22
 cc/compat_threads.c.gcov 75 53 41.41
 cc/compat.c.gcov 375 469 55.57
 cc/log.c.gcov 211 346 62.12
 cc/torgzip.c.gcov 73 138 65.40
 cc/procmon.c.gcov 13 28 68.29
 cc/compat_libevent.c.gcov 34 86 71.67
 cc/util.c.gcov 404 1309 76.42
 cc/workqueue.c.gcov 31 123 79.87
 cc/backtrace.c.gcov 11 47 81.03
 cc/compat_pthreads.c.gcov 19 88 82.24
 cc/crypto.c.gcov 166 800 82.82
 cc/memarea.c.gcov 16 91 85.05
 cc/address.c.gcov 67 622 90.28
 cc/crypto_ed25519.c.gcov 12 124 91.18
 cc/util_process.c.gcov 2 38 95.00
 cc/tortls.c.gcov 31 823 96.37
 cc/crypto_curve25519.c.gcov 3 85 96.59
 cc/crypto_pwbox.c.gcov 1 62 98.41
 cc/crypto_s2k.c.gcov 1 131 99.24
 cc/aes.c.gcov 0 20 100.00
 cc/container.c.gcov 0 424 100.00
 cc/crypto_format.c.gcov 0 91 100.00
 cc/di_ops.c.gcov 0 52 100.00
 cc/util_format.c.gcov 0 159 100.00
 TOTAL 1958 6256 76.16
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16791#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online