[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
     Type:  task                                 |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  tor-guard, tor-relay, prop237,       |        Version:  Tor:
  026-triaged-1, sebastian-review,               |  unspecified
  027-triaged-1-out, 028-triage, 028-triaged,    |     Resolution:
  mike-can, pre028-patch, TorCoreTeam201512,     |  Actual Points:
  201511-deferred                                |         Points:
Parent ID:                                       |  medium/large
  Sponsor:                                       |
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:94 nickm]:
 >
 > wrt f0a4282, I don't think we're changing the sense of the test --
 rather, we're changing the example-data that the test uses in order to
 make clients behave right.  Clients used to believe anything was a
 directory if it had a dirport -- now they require the is_v2_dir flag.
 Also, when we fixed the bug that let us pick directory guards that weren't
 guards, I think that did something to mess up the other test, which was
 testing for bad behavior. :/   But I don't know why that didn't show up in
 master.  Maybe I/we should investigate more?

 There is a unit test that makes sure we only choose guards with the guard
 flag, but it only applies to OR guards, not directory guards. I think
 that's why it didn't show up, as the bug was about directory guards.

 > Does that all seem right?

 That seems OK.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:95>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online