[tor-bugs] #12538 [Tor]: Make all relays automatically be dir caches

[Tor Bug Tracker & Wiki]

#12538: Make all relays automatically be dir caches
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
     Type:  task                                 |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  tor-guard, tor-relay, prop237,       |        Version:  Tor:
  026-triaged-1, sebastian-review,               |  unspecified
  027-triaged-1-out, 028-triage, 028-triaged,    |     Resolution:
  mike-can, pre028-patch, TorCoreTeam201512,     |  Actual Points:
  201511-deferred                                |         Points:
Parent ID:                                       |  medium/large
  Sponsor:                                       |
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:92 nickm]:
 > After squashing and merging to master, these tests failed:
 > {{{
 > nodelist/node_is_dir
 > config/directory_fetch
 > routerlist/pick_directory_server_impl
 > }}}
 >
 > I took a shot at fixing them, but I'd like somebody else to sanity-check
 whether my changes make sense in light of the test code.
 >
 > Please see the 3 latest commits on my branch "bug12538_merged":
 > {{{
 > f0a4282 fix routerlist/pick_directory_server_impl in light of 12538
 > f5f35e9 Fix config/directory_fetch after 12538 merge
 > a6c9fcc Fix nodelist/node_is_dir test wrt 12538.
 > }}}
 >
 > They're all very short.

 f0a4282 I can't understand why we're inverting the sense of the tests
 here. But I'm not familiar enough with the code or the tests to make a
 better suggestion.

 f5f35e9 is almost exactly what I expected to have to do once this merged.

 a6c9fcc looks plausible.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12538#comment:93>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online