[tor-bugs] #13171 [meek]: meek's reflector should forward the client's IP address/port to the bridge.

[Tor Bug Tracker & Wiki]

#13171: meek's reflector should forward the client's IP address/port to the bridge.
-------------------------+------------------------------
 Reporter:  yawning      |          Owner:  dcf
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:
Component:  meek         |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------

Comment (by dcf):

 I was curious as to what fraction of clients send `X-Forwarded-For`. On
 the meek-azure bridge, it is about 99.5%.

 I temporarily applied [attachment:0001-Count-fraction-of-hosts-with-X
 -Forwarded-For.patch​ this patch], which counts the number meek sessions
 that started with an `X-Forwarded-For` request. It prints stats after
 every 1000 new sessions. I let it run for 5000 sessions (it took 20
 minutes to get there).
 {{{
 useraddr:  total 5000  X-Forwarded-For 4978 good 0 bad  RemoteAddr 22 good
 0 bad  parse 5000 good 0 bad
 }}}
 This means, that out of 5000 requests, 4978 contained `X-Forwarded-For` or
 `Meek-IP`, and in all of those we were able to extract the client IP
 address from the header. For the remaining 22 requests, we fell back to
 the old behavior of using the source IP address (`RemoteAddr`). We were
 able to parse the resulting IP address in all 5000 cases.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13171#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online