[tor-bugs] #8195 [Tor]: tor and capabilities

[Tor Bug Tracker & Wiki]

#8195: tor and capabilities
-----------------------------------------------+---------------------------
 Reporter:  weasel                             |          Owner:
     Type:  enhancement                        |         Status:  reopened
 Priority:  Medium                             |      Milestone:  Tor:
Component:  Tor                                |  0.2.8.x-final
 Severity:  Normal                             |        Version:
 Keywords:  tor-relay, security, pre028-patch  |     Resolution:
Parent ID:                                     |  Actual Points:
  Sponsor:                                     |         Points:  small
-----------------------------------------------+---------------------------
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 Code introduced by this ticket causes Windows builds on Jenkins to fail. I
 have attached several patches which should fix the issues mentioned in the
 Jenkins logs.

 * Patch 1 prevents the switch id test from being run on Windows and hides
 the calls to `setuid` and `getuid` which are not available on Windows.
 * Patch 2 uses a Windows specific socket error code which is different
 from the one on Linux.
 * Patch 3 changes all calls to setsockopt to conform to both the POSIX and
 Windows implementations.
 * Patch 4 removes a Windows specific data type because a simple int works
 too.
 * Patch 5 adds some missing parentheses i found while working on related
 code.
 * Patch 6 improves a warning message to be consistent with the code.

 I have tried to keep the patches as small as possible to make reviewing
 easier.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8195#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online