[tor-bugs] #4483 [Tor]: If k of n authorities are down, k/n bootstrapping clients are delayed for minutes

[Tor Bug Tracker & Wiki]

#4483: If k of n authorities are down, k/n bootstrapping clients are delayed for
minutes
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  teor
     Type:  defect                               |         Status:
 Priority:  High                                 |  reopened
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  performance, bootstrap, dirauth-     |        Version:
  dos-resistance, tor-client, large-feature,     |     Resolution:
  prop210, 028-triage, TorCoreTeam201512,        |  Actual Points:
  MikePerry201512R                               |         Points:
Parent ID:  #2664                                |  medium/large
  Sponsor:  SponsorU                             |
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:54 cypherpunks]:
 > Replying to [comment:53 nickm]:
 > > My guess  (and this is just a guess) is that
 directory_fetches_from_authorities() is returning 0 because
 router_pick_published_address() is failing here.
 > Which means router_pick_published_address is actually succeeding when
 guessing our address while we're expecting it not to.

 Yes, I think I was getting a little worn out by all the unit tests at that
 point.

 Please see my branch `fix-multi-dir`, which:
 * Fixes an issue where some OR servers would bootstrap using multiple
 connections (and some clients would not)
  * This happened because directory_fetches_from_authorities and
 public_server_mode give pretty similar results for common cases
 * Ensures the fallback check works
 * Expands the failing unit test to check that relays, exits, and directory
 servers all fetch directories the way we expect
  * This test now mocks the relevant functions so the results don't depend
 on the machine

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4483#comment:55>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online