[tor-bugs] #17592 [Tor]: Clean up connection timeout logic

[Tor Bug Tracker & Wiki]

#17592: Clean up connection timeout logic
-----------------------+------------------------------------
 Reporter:  mikeperry  |          Owner:  mikeperry
     Type:  defect     |         Status:  needs_review
 Priority:  High       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor        |        Version:
 Severity:  Normal     |     Resolution:
 Keywords:             |  Actual Points:
Parent ID:  #16861     |         Points:
  Sponsor:             |
-----------------------+------------------------------------

Comment (by teor):

 Replying to [comment:9 mikeperry]:
 > Replying to [comment:7 teor]:
 > > In channelpadding_get_channel_idle_timeout:
 > > * I think `server_mode()` is the standard way of checking
 `options->BridgeRelay || !options->ORPort_set`. It does a few more checks,
 as far as I recall.
 >
 > Ok, I fixed this and another instance in fixup commits atop
 netflow_padding-v4.

 These fixups all look good. Are we going to merge this? :-)

 `options->BridgeRelay || !options->ORPort_set` is

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17592#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online