[tor-bugs] #17846 [Tor]: 32bit decimal IP address fail (i.e. no octets) on nbsd and obsd

[Tor Bug Tracker & Wiki]

#17846: 32bit decimal IP address fail (i.e. no octets) on nbsd and obsd
--------------------------+---------------------------
     Reporter:  amonk     |      Owner:
         Type:  defect    |     Status:  new
     Priority:  Very Low  |  Milestone:
    Component:  Tor       |    Version:  Tor: 0.2.6.10
     Severity:  Minor     |   Keywords:
Actual Points:            |  Parent ID:
       Points:            |    Sponsor:
--------------------------+---------------------------
 Tor 0.2.6.10 (at least) fails to start on NetBSD 7.0 (at least) and
 OpenBSD 5.8 (at least) when given a 32bit, decimal IP address for ORPort
 and/or DirPort.

 Example error:

 Dec 13 15:12:01.255 [warn] Couldn't parse address '"1755800511:443"' for
 ORPort
 Dec 13 15:12:01.256 [warn] Failed to parse/validate config: Invalid
 ORPort/ORListenAddress configuration

 Such addresses are legal inet_aton() addresses, and work, as they should,
 on the following, other Tor/OS combinations...

 tor 0.2.6.10 on FreeBSD 10.1
 tor 0.2.6.9 on DragonFly BSD 4.2.3.1
 tor 0.2.7.4-rc-1 on Debian GNU/Linux 8.2
 tor 0.2.7.5-1 on Debian GNU/Hurd (hurd 0.7, Mach 1.6)

 So, it looks like a pretty esoteric issue with NetBSD and OSs thereby
 derived, at least from some point in its history that includes OpenBSD.

 I tracked it to tor_addr_parse(), but that's as far as I got.

 It's certainly a non-critical, limited exposure, fringe case,
 but something is obviously amiss.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17846>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online